Skip to content

fix: payment history is now a number instead of a bool #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

fix: payment history is now a number instead of a bool #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions include/pro/pro.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class ProWrapper : public Napi::ObjectWrap<ProWrapper> {
// "requestVersion": number,
// "masterPrivKeyHex": string,
// "unixTsMs": number,
// "withPaymentHistory": boolean,
// "count": number,
// }

assertInfoLength(info, 1);
Expand All @@ -255,12 +255,10 @@ class ProWrapper : public Napi::ObjectWrap<ProWrapper> {

assertIsNumber(first.Get("requestVersion"), "proStatusRequestBody.requestVersion");
assertIsNumber(first.Get("unixTsMs"), "proStatusRequestBody.unixTsMs");
assertIsBoolean(
first.Get("withPaymentHistory"), "proStatusRequestBody.withPaymentHistory");
assertIsNumber(first.Get("count"), "proStatusRequestBody.count");
auto requestVersion = first.Get("requestVersion").As<Napi::Number>();
auto unix_ts_ms = toCppSysMs(first.Get("unixTsMs"), "proStatusRequestBody.unixTsMs");
auto withPaymentHistory = toCppBoolean(
first.Get("withPaymentHistory"), "proStatusRequestBody.withPaymentHistory");
auto count = toCppInteger(first.Get("count"), "proStatusRequestBody.count");
assertIsString(first.Get("masterPrivKeyHex"), "proStatusRequestBody.masterPrivKeyHex");

auto master_privkey_js = first.Get("masterPrivKeyHex");
Expand All @@ -273,7 +271,7 @@ class ProWrapper : public Napi::ObjectWrap<ProWrapper> {
static_cast<uint8_t>(requestVersion.Int32Value()),
to_span(master_privkey_decoded),
unix_ts_ms,
withPaymentHistory);
count);

return json;
});
Expand Down
2 changes: 1 addition & 1 deletion types/pro/pro.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ declare module 'libsession_util_nodejs' {
args: WithMasterPrivKeyHex &
WithRequestVersion &
WithUnixTsMs & {
withPaymentHistory: boolean;
count: number;
}
) => string;
};
Expand Down
Loading