Skip to content

chore: add datatestids to empty states #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

chore: add datatestids to empty states #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ts/components/EmptyMessageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export const EmptyMessageView = () => {
$flexDirection="column"
$justifyContent="center"
$alignItems="center"
data-testid={newAccountCreated ? 'empty-msg-view-account-created' : 'empty-msg-view-welcome'}
>
{newAccountCreated ? (
<>
Expand Down
3 changes: 3 additions & 0 deletions ts/react.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ declare module 'react' {
| `${NotificationRadioButtons}`
| `avatar-${Avatars}`
| `pro-badge-${ProBadges}`
// empty msg view ids
| 'empty-msg-view-account-created'
| 'empty-msg-view-welcome'
| 'last-updated-timestamp'
| 'account-id-pill'
// Once the whole app have datatestId when required, this `invalid-data-testid` will be removed
Expand Down
Loading