Skip to content

fix: make sure we iterate over qualities for img resize #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: make sure we iterate over qualities for img resize #1666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ts/webworker/workers/node/image_processor/image_processor.worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,9 +744,7 @@ const workerActions: ImageProcessorWorkerActions = {

// if we can't get a picture with a quality of more than 30, consider it a failure and return null
const qualityRange = [95, 85, 75, 55, 30] as const;
let qualityRangeIndex = 0;
while (qualityRangeIndex < qualityRange.length) {
const quality = qualityRange[qualityRangeIndex];
for (const quality of qualityRange) {
const pipeline = base.clone();

switch (metadata.format) {
Expand Down Expand Up @@ -797,15 +795,14 @@ const workerActions: ImageProcessorWorkerActions = {
};
}
logIfOn(
`[imageProcessorWorker] processForFileServerUpload: iteration[${qualityRangeIndex}] took so far ${
`[imageProcessorWorker] processForFileServerUpload: took so far ${
Date.now() - start
}ms with quality ${quality}`
);
logIfOn(
`\t src${formattedMetadata({ width: metadata.width, height: metadata.height, format: metadata.format, size: inputBuffer.byteLength })} `
);
}
qualityRangeIndex++;

logIfOn(
`[imageProcessorWorker] processForFileServerUpload: failed to get a buffer of size ${maxSizeBytes} for ${inputBuffer.byteLength} bytes for image of ${metadata.width}x${metadata.height} with format ${metadata.format}`
Expand Down
Loading