feat(frontend/settings): combine vishraam color toggles#561
Merged
harjot1singh merged 1 commit intoshabados:devfrom May 29, 2020
bhajneet:issue-371
Merged
feat(frontend/settings): combine vishraam color toggles#561harjot1singh merged 1 commit intoshabados:devfrom bhajneet:issue-371
harjot1singh merged 1 commit intoshabados:devfrom
bhajneet:issue-371
Conversation
harjot1singh
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR
Combined the vishraam toggles instead of having two toggles for gurbani/translit. If we are treating larrivaar the same regardless of gurbani/translit, we should do the same for vishraam colors.
Tests for unexpected behavior
Time spent on PR
15 mins
Linked issues
fix #371
Reviewers
@harjot1singh