Remove redundant readthedocs triggers and stable branch check #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #88 and #89, this change removes the redundant RTD webhook triggering that did not work properly, now that pushes to the repo from the GH actions works without a manual trigger.
It also removes a check for changes from the stable branch update, since it checks if there were any changes to main, when really it should be checking for diffs between main and stable. If after the submodules were last automatically updated there have been no additional changes to main or to the submodules, the faulty check will cause the update to stable to skip. Since there will always be a diff between main and stable (slang submodule checked out from different branch) the check, even if done properly, is redundant too.