Skip to content

Conversation

@jkwak-work
Copy link
Contributor

@jkwak-work jkwak-work commented Oct 29, 2024

@jkwak-work jkwak-work self-assigned this Oct 29, 2024
@jkwak-work jkwak-work requested a review from csyonghe November 5, 2024 18:28
In Slang, the generic relies on the definition of "interface" and it allows the compiler to skip a few steps that the template implementation couldn't.


### Shader Runtime Debugging with RenderDoc and NSIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of stating "may work" which is not that useful, describe slang's support of

  1. Controlling turning on or off line directives
  2. A link to the spirv cross compile doc for people interested in how cross compile works in slang.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where this document is,

A link to the spirv cross compile doc for people interested in how cross compile works in slang.

Did you mean this document?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean the spirv specific feature doc you wrote earlier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csyonghe
Copy link
Contributor

csyonghe commented Nov 8, 2024

I also recommend running the text through an LLM and see if we can make the text a bit more fluent.

Hai had a presentation about Slang at SIGGRAPH 2024.
Two slices are relavent to this document.
@jkwak-work
Copy link
Contributor Author

jkwak-work commented Nov 9, 2024

I also recommend running the text through an LLM and see if we can make the text a bit more fluent.

I used HTML "table" to show the code snippets side-by-side.
I also ran LLM to make the sentences more natural to read.

@jkwak-work jkwak-work merged commit 734833e into shader-slang:main Nov 13, 2024
@jkwak-work jkwak-work deleted the doc/migrating_from_hlsl branch November 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tutorial] the first draft of on-ramp tutorial (for HLSL)

2 participants