Skip to content

Improve eval() in command executor #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2020
Merged

Improve eval() in command executor #46

merged 3 commits into from
May 29, 2020

Conversation

Systho
Copy link
Contributor

@Systho Systho commented Mar 25, 2020

allow eval to use correct filename, this will produce better stacktrace and allow things like require_relative in eval'd files

@Systho
Improve eval() in command executor
179c9df 
allow eval to use correct filename, this will produce better stacktrace and allow things like `require_relative` in eval'd files
@grantspeelman grantspeelman self-assigned this Mar 25, 2020
@grantspeelman
Copy link
Collaborator

Thank you 👍

@grantspeelman
Copy link
Collaborator

Sorry about the delay in merging this, totally slipped my mind

@grantspeelman grantspeelman merged commit 1985240 into shakacode:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantspeelman grantspeelman grantspeelman approved these changes

Assignees

@grantspeelman grantspeelman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Systho @grantspeelman