Skip to content

Improve eval() in command executor #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2020
Merged

Improve eval() in command executor #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
179c9df
Improve eval() in command executor
Systho Mar 25, 2020
24d91c0
Update CHANGELOG.md
grantspeelman Mar 25, 2020
65b289e
Merge branch 'master' into patch-1
grantspeelman May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## [Unreleased]
[Compare]: https://github.com/shakacode/cypress-on-rails/compare/v1.6.0...master

### Changed
* Improve eval() in command executor [PR 46](https://github.com/shakacode/cypress-on-rails/pull/46) by [Systho](https://github.com/Systho)

### Fixed
* Add middleware after load_config_initializers [PR 62](https://github.com/shakacode/cypress-on-rails/pull/62) by [duytd](https://github.com/duytd)

Expand Down
2 changes: 1 addition & 1 deletion lib/cypress_on_rails/command_executor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class CommandExecutor
def self.load(file,command_options = nil)
load_cypress_helper
file_data = File.read(file)
eval file_data
eval file_data, binding, file
rescue => e
logger.error("fail to execute #{file}: #{e.message}")
logger.error(e.backtrace.join("\n"))
Expand Down