Added some basic test coverage for the helpers

[mapreal19]

• Resolves Add Unit tests #5

[mapreal19]

@samnang @justin808 am I missing something here? I'm getting console is undefined on the specs

[justin808]

be sure that you're working off of the latest. Rebase your changes on top of the latest.

[justin808]

@mapreal19 We're doing a lot of reworking of the internals, so I'd first focus on the capybara tests. Especially important to get a test that verifies the created HTML for server rendering.

You might want to use the same driver we use in https://github.com/shakacode/react-webpack-rails-tutorial

[mapreal19]

@justin808 👍

[samnang]

@mapreal19 I totally agree with @justin808 . We start with integration level is better because a lot of changes haven't merged, but the functionality should be the same.

[justin808]

@mapreal19 Can you tune this up, and let's merge this if appropriate.

[justin808]

@robwise Can you pull this into your own fork and see if this helps with coverage? Thanks.

[robwise]

@justin808 Coverage is the same, but it slightly increases the hits per line. Also, two of the tests were failing because I believe they were calling the wrong method, so I fixed those. One was also expecting a message that actually had an additional line return and blank space in the result. I matched it to pass, but I'm not sure if that's what we want or not.

The tests are not redundant with what we've already got, so I think they have value regardless.

Before:

After:

[justin808]

@robwise can you rebase this on top of master?

[robwise]

@justin808 Done just now, it's up on #66

Do we have any more info about the whitespace thing?

[justin808]

@robwise Regarding the whitspace thing, you'd want to look at the source. My guess is that there is just whitespace in the ERB file around the tag.