-
-
Notifications
You must be signed in to change notification settings - Fork 638
Added some basic test coverage for the helpers #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
--format documentation | ||
--color | ||
--require spec_helper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
require "rails_helper" | ||
|
||
describe ReactOnRailsHelper do | ||
describe "#react_component" do | ||
subject { react_component("App") } | ||
|
||
let(:react_component_div) do | ||
"<div id=\"App-react-component-0\"></div>" | ||
end | ||
|
||
it { expect(self).to respond_to :react_component } | ||
|
||
it { is_expected.to be_an_instance_of ActiveSupport::SafeBuffer } | ||
it { is_expected.to start_with "<script>" } | ||
it { is_expected.to end_with "</div>\n\n" } | ||
it { is_expected.to include react_component_div } | ||
|
||
context "with 'id' option" do | ||
subject { react_component("App", {}, id: id) } | ||
|
||
let(:id) { "shaka_div" } | ||
|
||
it { is_expected.to include id } | ||
it { is_expected.not_to include react_component_div } | ||
end | ||
end | ||
|
||
describe "#render_js" do | ||
subject { render_js("this.HelloString.world()") } | ||
|
||
let(:hello_world) do | ||
"Hello WORLD! Will this work?? YES! Time to visit Maui\n" | ||
end | ||
|
||
it { expect(self).to respond_to :react_component } | ||
|
||
it { is_expected.to be_an_instance_of ActiveSupport::SafeBuffer } | ||
it { is_expected.to eq hello_world } | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samnang @justin808 am I missing something here? I'm getting
console
is undefined on the specsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be sure that you're working off of the latest. Rebase your changes on top of the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapreal19 We're doing a lot of reworking of the internals, so I'd first focus on the capybara tests. Especially important to get a test that verifies the created HTML for server rendering.
You might want to use the same driver we use in https://github.com/shakacode/react-webpack-rails-tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin808 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapreal19 I totally agree with @justin808 . We start with integration level is better because a lot of changes haven't merged, but the functionality should be the same.