Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ rvm:
- 2.2.2
gemfile:
- spec/dummy/Gemfile
install: bundle install
install:
- bundle install
- cd spec/dummy && bundle install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samnang @justin808 am I missing something here? I'm getting console is undefined on the specs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be sure that you're working off of the latest. Rebase your changes on top of the latest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mapreal19 We're doing a lot of reworking of the internals, so I'd first focus on the capybara tests. Especially important to get a test that verifies the created HTML for server rendering.

You might want to use the same driver we use in https://github.com/shakacode/react-webpack-rails-tutorial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mapreal19 I totally agree with @justin808 . We start with integration level is better because a lot of changes haven't merged, but the functionality should be the same.

- npm install
- cd -
script:
- rake run_rspec:gem
- rake run_rspec:dummy
Expand Down
1 change: 1 addition & 0 deletions spec/dummy/.rspec
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
--format documentation
--color
--require spec_helper
40 changes: 40 additions & 0 deletions spec/dummy/spec/helpers/react_on_rails_helper_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
require "rails_helper"

describe ReactOnRailsHelper do
describe "#react_component" do
subject { react_component("App") }

let(:react_component_div) do
"<div id=\"App-react-component-0\"></div>"
end

it { expect(self).to respond_to :react_component }

it { is_expected.to be_an_instance_of ActiveSupport::SafeBuffer }
it { is_expected.to start_with "<script>" }
it { is_expected.to end_with "</div>\n\n" }
it { is_expected.to include react_component_div }

context "with 'id' option" do
subject { react_component("App", {}, id: id) }

let(:id) { "shaka_div" }

it { is_expected.to include id }
it { is_expected.not_to include react_component_div }
end
end

describe "#render_js" do
subject { render_js("this.HelloString.world()") }

let(:hello_world) do
"Hello WORLD! Will this work?? YES! Time to visit Maui\n"
end

it { expect(self).to respond_to :react_component }

it { is_expected.to be_an_instance_of ActiveSupport::SafeBuffer }
it { is_expected.to eq hello_world }
end
end