Various fixes and improvements #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2021
shannah
reviewed
Jan 6, 2021
Marcono1234
force-pushed
the
marcono1234/fixes
branch
from
f6fcfca to
6236627
Compare
It appears javadoc (and Eclipse IDE) does not support javadoc comments for multiple fields as part of the same declaration.
Lazy initialization only makes sense for large objects or objects whose
creation is expensive, however this is not the case here.
Also removes redundant `{@inheritdoc}` javadoc comments because documentation
is inherited by default if no javadoc comment exists.
Instead replace it with `instanceof` checks. This also removes impossible instance checks for primitives because an Object can never be an instance of a primitive.
Marcono1234
force-pushed
the
marcono1234/fixes
branch
from
6e8af61 to
d3607fe
Compare
Previously the project used the outdated library in src/main/resources/ instead of the library it had built from source.
Removed repositories entries because it appears mvnrepository.com is itself not a repository but only a browser for repositories so might have been ignored by Maven.
Marcono1234
force-pushed
the
marcono1234/fixes
branch
from
d3607fe to
6da9170
Compare
|
I will mark this pull request as "Ready for review" now, please let me know if you want anything changed or if you want this pull request to be split into multiple ones. I have not verified that all upgraded Maven plugins still work, please let me know if you want any plugin upgrades to be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits messages describe the respective changes.
Please let me know if you want anything changed or whether I should split this pull request.