Skip to content

Allow additional configuration metadata to VM during deployment #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Allow additional configuration metadata to VM during deployment #19

wants to merge 10 commits into from

Conversation

@dhlaluku
Copy link

@dhlaluku dhlaluku commented Jul 25, 2018

Description

Currently, CloudStack does not allow additional configuration metadata to guest VMs during deployment. This feature aims to provide operators the functionality to pass arbitrary additional configuration metadata that will be included everytime the guest VM is started.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@dhlaluku dhlaluku changed the title [WIP] Allow additional configuration metadata to VM during deployment [WIP] Allow additional configuration metadata to VM during deployment (review) Jul 25, 2018
@rohityadavcloud rohityadavcloud changed the base branch from master to 4.0 July 25, 2018 09:43
@rohityadavcloud rohityadavcloud changed the base branch from 4.0 to master July 25, 2018 09:43
nvazquez
nvazquez reviewed Aug 2, 2018
View reviewed changes
nvazquez
nvazquez reviewed Aug 2, 2018
View reviewed changes
nvazquez
nvazquez reviewed Aug 2, 2018
View reviewed changes
nvazquez
nvazquez reviewed Aug 2, 2018
View reviewed changes
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from a107bc3 to 43103ff Compare August 14, 2018 09:07
nvazquez
nvazquez reviewed Aug 15, 2018
View reviewed changes
nvazquez
nvazquez reviewed Aug 15, 2018
View reviewed changes
rohityadavcloud
rohityadavcloud requested changes Aug 23, 2018
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good work Dingane, left some comments and TODOs.

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Aug 23, 2018

@dhlaluku can you also rebase against latest master and fix conflicts.

nvazquez
nvazquez reviewed Aug 28, 2018
View reviewed changes
nvazquez
nvazquez reviewed Aug 28, 2018
View reviewed changes
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from badb526 to bec3e28 Compare August 28, 2018 14:32
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from 96189b3 to 0fa8aa0 Compare October 11, 2018 08:53
@rohityadavcloud rohityadavcloud changed the base branch from master to 4.11 October 11, 2018 09:20
@rohityadavcloud rohityadavcloud changed the base branch from 4.11 to master October 11, 2018 09:20
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from 0fa8aa0 to 3f5c7e9 Compare October 12, 2018 08:25
borisstoyanov
borisstoyanov reviewed Nov 27, 2018
View reviewed changes
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from 65921a2 to 1fa4375 Compare November 27, 2018 08:51
@dhlaluku dhlaluku changed the base branch from master to 4.11 November 27, 2018 08:53
borisstoyanov
borisstoyanov reviewed Dec 6, 2018
View reviewed changes
borisstoyanov
borisstoyanov reviewed Dec 6, 2018
View reviewed changes
@borisstoyanov
Copy link
Member

borisstoyanov commented Dec 6, 2018 •
edited
Loading

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enable+additional+configuration+metadata+to+virtual+machines

@dhlaluku
Copy link
Author

dhlaluku commented Dec 17, 2018

@nvazquez @DaanHoogland, please review

@dhlaluku
Copy link
Author

dhlaluku commented Dec 19, 2018

@nvazquez @DaanHoogland @rhtyd may you please have a look at this PR. @rhtyd you requested changes a while back when you reviewed this PR, please have another and advice on any revisions required.

@dhlaluku dhlaluku changed the title [WIP] Allow additional configuration metadata to VM during deployment (review) Allow additional configuration metadata to VM during deployment Mar 1, 2019
@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from 96dc83d to fcb7d86 Compare March 7, 2019 13:23
@dhlaluku dhlaluku changed the base branch from master to 4.11 March 9, 2019 11:39
@dhlaluku dhlaluku changed the base branch from 4.11 to master March 9, 2019 11:40
borisstoyanov
borisstoyanov reviewed Mar 11, 2019
View reviewed changes
test/integration/smoke/test_deploy_vm_extra_config_data.py Outdated
host = list_hosts(
self.apiclient,
id=host_id,
hypervisor='kvm')
Copy link
Member

@borisstoyanov borisstoyanov Mar 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be 'kvm' hardcoded, but instead use 'testClient.getHypervisorInfo()' to set a class var. In this case hypervisors !=kvm will run

Copy link
Author

@dhlaluku dhlaluku Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, now using self.hypervisor.lower()

@dhlaluku dhlaluku force-pushed the allow-additional-config-to-vms branch from 4d2cc85 to 4d1d4f4 Compare March 12, 2019 14:08
nvazquez and others added 7 commits July 17, 2019 20:13
@nvazquez @rohityadavcloud
ui: Fix SystemVMs public range dedication (apache#3495)
a1faf09 
Fix small UI issue when dedicating public IR range for system VMs:
Unable to execute API command createvlaniprange due to invalid value. Invalid parameter domainid value=undefined due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.

Fixes: apache#3485
@nvazquez
KVM: Enhancements for direct download feature (apache#3374)
a1a9fb8 
* Add revoke certificates API

* Add background task to sync certificates

* Fix marvin test and revoke certificate

* Fix certificate sent to hypervisor was missing headers

* Fix background task for uploading certificates to hosts
@rohityadavcloud
Allow users to share templates with Accounts or Projects through the UI
5d81574 
* Allow users to share templates with Accounts or Projects through the
updateTemplate permissions API

* Change behaviour to show only supported projects and accounts with update template permissions

* Allow admins to see accounts dropdown and only hide lists for users

* Don't allow sharing project owned templates as you cannot retrieve them in list api calls
@rohityadavcloud
server: disable unauthenticated integration.api.port by default (apac…
6a336f8 
…he#3504)

Set integration.api.port to (0) zero as default. CloudStack provides CloudStack API Unauthenticated Access through port 8096. It should not be open to the Internet in any case.
@rohityadavcloud
vmware: fix volume stats logic (apache#3473)
e1fa270 
During volume stats calculation, if a volume has more than one disk in
the chain-info it is not used to sum the physical and virtual size
in the loop, instead any previous entry was overwritten by the last disk.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@nvazquez @rohityadavcloud
server: Fix hardcoded max data volumes when VM has been created but n…
38f97c6 
…ot started before (apache#3494)

When VM is created but not started on any host, attaching a volume on it causes the maximum number of allowed volumes to be 6 (hardcoded).
@rohityadavcloud
server: fix the subnet overlap checking logic for tagged and untagged…
5690cd6 
… vlans when adding ipranges (apache#3430)

Fixes: apache#3114

When adding iprange for VLANs there are 3 cases -

VLAN under consideration has a tag (like 101)
VLAN under consideration has a tag but as a range (like 101-124)
VLAN is untagged (i.e. id is "untagged")
Before adding iprange we have to check for possible overlaps and throw exception. This needs to be done as follows -

If VLAN Tag ID is numeric or a range we need to call UriUtils.checkVlanUriOverlapmethod which internally tries to expand the range as verifies if there are overlaps. If URI overlaps (i.e. there are overlapping VLAN tags) we then need to verify if the iprange being added overlaps with previously added ranges.
If there are no overlapping tags we simply need to test for public networks being present in the VLAN.
A Regression was introduced in 41fdb88#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174 which caused comparing 'untagged' string as a numeric VLAN Tag range and and attempted expanding it to test overlap in UriUtils.checkVlanUriOverlap.

To fix the bug in the issue, we need to handle the untagged case separately as it's non-numeric tag in code. For untagged VLANs and overlapping VLAN URIs we need to check for ipranges and gateways which happens naturally after this change. For tagged VLANs with non-overlapping URIs we need to check if there is a public network.
@borisstoyanov
Copy link
Member

borisstoyanov commented Jul 23, 2019

@rhtyd @nvazquez @shwstppr @anuragaw, this is FR04 from the roadmap items, it needs to be rebased and there's merge conflicts.

Dingane Hlaluku and others added 3 commits July 23, 2019 15:06
Suqash commits to a single commit and rebase against master
1c8bc3b 
Update marvin tests to use white list
* Fix marvin test failure
be39548 
* Add new marvin negative tests cases
* Remove hard-coded hypervisor types in marvin tests
Fix build error after rebase and add hugepagesless
d0fcd97
@anuragaw anuragaw force-pushed the allow-additional-config-to-vms branch from 6e864b7 to d0fcd97 Compare July 23, 2019 10:17
@anuragaw
Copy link

anuragaw commented Jul 23, 2019

Closing this and opening a public PR as advised.

@anuragaw anuragaw closed this Jul 23, 2019
rohityadavcloud pushed a commit that referenced this pull request Jan 20, 2021
@onitake @rohityadavcloud
eslint: fix missing eslint dependencies and lint errors (#19)
eebf7fa 
Fixes: #17
Fixes: #18

These dependencies are necessary or eslint will fail with the standard vue.js rule set.
The PR also includes fixes for all lint errors.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr pushed a commit that referenced this pull request Jul 27, 2021
@Pearl1594
ssvm: Check to prevent redownloaded of downloaded templates (#19)
46a8454 
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
rohityadavcloud pushed a commit that referenced this pull request Oct 16, 2024
@nvazquez
Merge pull request #19 from shapeblue/fix-userkeys-cve
b458e5b 
[4.18] server, api: account and api entity access improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez left review comments

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dhlaluku @rohityadavcloud @borisstoyanov @anuragaw @nvazquez