WIP api: instances settings for templates and VMs are free text #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhlaluku
force-pushed
the
vm-templates-instance-settings
branch
from
77035f8 to
6ee0003
Compare
rohityadavcloud
changed the title
* Refactor hard-coded vm detail constants to VmDetailConstants interface
rohityadavcloud
force-pushed
the
vm-templates-instance-settings
branch
from
6ee0003 to
0c0554d
Compare
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
... want users to see Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
… fixes (#59) Add actions from old UI to new UI Fixes: #40 Doing the following: Extract out actions from old UI to new for infra section - zones, pods, clusters, ...etc. Support translation of labels for actions instead of hard coding them Translation of action buttons in list view, detail view, forms and also their fields will now be human readable. Some misc changes - like comparing API param names with case insensitive stuff, allowing reusing of same API for multiple actions by passing defaultArgs: to action in config files. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
pushed a commit
that referenced
this pull request
Jul 27, 2021
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Users don't know what keys/values to enter for template and VM details.
Root Cause: The feature does not exist that can list possible details and options.
Solution: Based on the possible VM and template details handled by the codebase, those details were refactored and a list API is introduced that can return users those details along with possible values. When users add details now, they will be presented with a list of key details and their possible options if any.
Types of changes
Screenshots (if appropriate):