PR for review purposes only vSphere advanced capabilities #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanHoogland
changed the title
DaanHoogland
commented
May 25, 2020
| # From https://my.vmware.com/group/vmware/details?downloadGroup=WEBCLIENTSDK67U2&productId=742 | ||
| mvn install:install-file -Dfile=vim25_67.jar -DgroupId=com.cloud.com.vmware -DartifactId=vmware-vim25 -Dversion=6.7 -Dpackaging=jar | ||
|
|
||
| mvn install:install-file -Dfile=pbm_65.jar -DgroupId=com.cloud.com.vmware -DartifactId=pbm -Dversion=6.5 -Dpackaging=jar |
Member
Author
There was a problem hiding this comment.
is this really not in mvn central? I understood Vmware made all their libs redist??
Member
Author
There was a problem hiding this comment.
guess not, i now see the same for the old API. still seems off, though.
Member
Author
There was a problem hiding this comment.
can you add a link like in the one above?
DaanHoogland
commented
May 25, 2020
| @@ -0,0 +1,53 @@ | |||
| package com.cloud.hypervisor.vmware.mo; | |||
DaanHoogland
commented
May 25, 2020
Comment on lines
+78
to
+83
| <dependency> | ||
| <groupId>com.cloud.com.vmware</groupId> | ||
| <artifactId>pbm</artifactId> | ||
| <version>${cs.vmware.api.version}</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
Member
Author
There was a problem hiding this comment.
this is called from both the hypervisor plugin and from the base lib. That does not seem like proper isolation.
DaanHoogland
commented
May 25, 2020
|
|
||
| import java.util.List; | ||
|
|
||
| public class PbmProfileManagerMO extends BaseMO { |
Member
Author
There was a problem hiding this comment.
what does this class provide me? can we have that in javadoc?
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
This adds the rules tab for IAM/roles. Fixes #45 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?