Fixes webhooks attempting to authenticate #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikandersen
approved these changes
Nov 7, 2023
Contributor
ulrikandersen
left a comment
ulrikandersen
left a comment
There was a problem hiding this comment.
Dependency injection 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where our web hooks would attempt to access the user session, however, no user is logged in when executing a webhook.
The regression was introduced in #113 where we decorate our GitHubClient with a AccessTokenRefreshingGitHubClient which makes all invocations of GitHubClient authenticated. However, that causes errors when using the GitHub client through a webhook.
To fix the issue we ensure that our webhooks do not use an instance of AccessTokenRefreshingGitHubClient but rather uses an instance of GitHubClient directly.