Adds ForgivingProjectDataSource #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ForgivingProjectDataSource which returns an empty set of projects when we fail to fetch the user's access token.
These changes are introduced to improve our support for guest users. When a guest user is incorrectly configured to have access to a non-existing repository, we will not be able to create their access token as it is tied to a list of repositories. Therefore we regard the user as having access to no repositories when we fail to obtain their access token.
This logic is in theory applied for host users, i.e. GitHub users too, however, we have other logic in place to ensure that we have a valid access token for those users before they are even allowed to login. This is not the case for guest users as that could prevent them from logging in when they are configured to have access to non-existing repositories.