Skip to content

Proxies all blob requests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Proxies all blob requests #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc797b8
Proxies all blob requests
simonbs Nov 8, 2023
47d8a9d
Moves /api/github/blob to /api/blob
simonbs Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ...b/[owner]/[repository]/[...path]/route.ts → ...b/[owner]/[repository]/[...path]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,12 @@ export async function GET(req: NextRequest, { params }: { params: GetBlobParams
})
const url = new URL(item.downloadURL)
const imageRegex = /\.(jpg|jpeg|png|webp|avif|gif)$/;

const file = await fetch(url).then(r => r.blob())
const headers = new Headers()
if (new RegExp(imageRegex).exec(path)) {
const file = await fetch(url).then(r => r.blob());
const headers = new Headers();
const cacheExpirationInSeconds = 60 * 60 * 24 * 30 // 30 days

headers.set("Content-Type", "image/*");
headers.set("Cache-Control", `max-age=${cacheExpirationInSeconds}`);

return new NextResponse(file, { status: 200, headers })
} else {
return NextResponse.redirect(url)
headers.set("Cache-Control", `max-age=${cacheExpirationInSeconds}`)
}
return new NextResponse(file, { status: 200, headers })
}
2 changes: 1 addition & 1 deletion src/features/projects/data/GitHubProjectDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,6 @@ export default class GitHubProjectDataSource implements IProjectDataSource {
}

private getGitHubBlobURL(owner: string, repository: string, path: string, ref: string): string {
return `/api/github/blob/${owner}/${repository}/${path}?ref=${ref}`
return `/api/blob/${owner}/${repository}/${path}?ref=${ref}`
}
}