Skip to content

Conversation

@mpabarca
Copy link
Contributor

@mpabarca mpabarca commented Jul 22, 2024

Description

Add "Add new project" button to Sidebar Header that redirects to shape-docs wiki page.

Motivation and Context

  • A small button on Shape Docs to get people started on the platform it become more relevant cause is been open the service to more people.

In order to do that is was added a new .env variable NEXT_PUBLIC_SHAPE_DOCS_PROJECT_WIKI_URL that has the URL of the wiki page.

Screenshots:

Screenshot 2024-07-23 at 09 43 54

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mpabarca mpabarca self-assigned this Jul 22, 2024
@github-actions
Copy link

⚠️ It looks like .env.example has changed. Remember to update the Setting Environment Variables article accordingly.

@mpabarca mpabarca force-pushed the feature/add-new-project-button branch from 789b9c2 to 01651e9 Compare July 22, 2024 15:24
@mpabarca
Copy link
Contributor Author

@ulrikandersen @simonbs
Once we merge this change, we need to add the .env key NEXT_PUBLIC_SHAPE_DOCS_PROJECT_WIKI_URL to the variables on the deployment platform (AWS?)

@simonbs
Copy link
Contributor

simonbs commented Jul 25, 2024

Following our talk yesterday, I have moved the button that opens the wiki into the user menu in the lower-left corner and renamed it "Help".

It's now using an environment variable named NEXT_PUBLIC_SHAPE_DOCS_HELP_URL instead of NEXT_PUBLIC_SHAPE_DOCS_PROJECT_WIKI_URL, as the button doesn't have to link to our wiki but could be configured to link to any internal documentation.

The "Add New Project" button has been left in the codebase but commented out as we'll need it soon.

Screenshot 2024-07-25 at 08 09 17

Copy link
Contributor Author

@mpabarca mpabarca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbs simonbs merged commit f0fc183 into develop Jul 25, 2024
@simonbs simonbs deleted the feature/add-new-project-button branch July 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants