Restructures layout for increased flexibility and performance #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncement/adds-avatars-to-logins # Conflicts: # src/features/projects/data/GitHubLoginDataSource.ts
|
|
ulrikandersen
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ This PR depends on #279 and should not be merged before that PR is merged.
The changes in this PR restructures the layout of the application, and as such, also big parts of the codebase, for two reasons:
A great benefit of the second point is that this addresses the issue where the sidebar's scroll position was reset after selecting a project.
The changes are significant, so I do not expect anyone to do a full review of this codebase. I know it's not Do Right but I suggest that we get this PR merged, test the web app thoroughly, and fix any issues that may arise along the way.