Skip to content

Use site name as a prefix for sign in texts #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

Use site name as a prefix for sign in texts #298

merged 1 commit into from
Jul 30, 2024

Conversation

@ulrikandersen
Copy link
Contributor

@ulrikandersen ulrikandersen commented Jul 30, 2024 •
edited
Loading

This PR replaces the hardcoded Shape Docs with site name as the prefix for the sign in texts to maintain the configurability of the app.

Screenshots (if appropriate):

Screenshot 2024-07-30 at 14 38 40

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@ulrikandersen ulrikandersen marked this pull request as ready for review July 30, 2024 12:42
@ulrikandersen ulrikandersen requested a review from simonbs as a code owner July 30, 2024 12:42
@ulrikandersen ulrikandersen enabled auto-merge July 30, 2024 12:46
@ulrikandersen ulrikandersen merged commit 1e3d30d into develop Jul 30, 2024
@ulrikandersen ulrikandersen deleted the fix/use-site-name-for-sign-in-texts branch July 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonbs simonbs simonbs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulrikandersen @simonbs