-
Notifications
You must be signed in to change notification settings - Fork 2
feat: New Project page #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
AWESOME!! 🚀 I'm on vacation now but will make sure to go through the changes once I'm back on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of comments to the files. Below are a few more general questions 😊
Is the highlighted text off by one character?
I love the highlighted text feature—such a fun touch! It seems like the highlight is consistently one character too long, though. I’ve pointed this out in the screenshot below. Is there an easy way to adjust that?
Should we reduce the number of documentation links?
Linking to the documentation is a great idea. However, the multiple "(?)" links might add a bit of clutter and make it seem like there’s a lot more to read than necessary. Would it be enough to just have the "Read more about Adding Documentation to Shape Docs" link at the bottom?
Can we link the user to the project?
Wouldn’t it be cool if step four linked directly to the documentation on Shape Docs? Since the user enters the project name, we could use that to generate the URL. Maybe we show the link after the "Create Repository" button is clicked? We could eventually have it poll the project list to confirm creation, but I don’t think that’s needed right away.
Looking at it again, removing these links would also eliminate another challenge, albeit a small one. The links behind the "(?)" buttons currently assume that the |
@simonbs completely right. I had considered this issue before but thought the value provided was more important than future-proofing. However, after getting a second opinion, I agree—it didn’t add much value, so it’s better to remove them. |
@simonbs This would be awesome! However, we might encounter an issue when adding this feature: determining the repository owner. To redirect, we would use this format: Initially, we could assume that the owner could be inferred from the template key, e.g., Another scenario to consider is that the user might change the project name on GitHub without us knowing. This could result in redirecting to the wrong or a non-existent repository. |
Right, that's a good point. I did not think of that. Let's abandon this idea for now. |
simonbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Create project button on sidebar header that link to page on shape-docs that helps on the creation of a new openapi repository on github following this guidance and this base url:
https://github.com/new?name={...}&description={...}&template_owner={...}&template_name={...}Motivation and Context
Screenshots:
V3



Types of changes