Uses Suspense when loading projects #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made in response to this comment from @mpabarca, which raises a great point that Shape Docs isn't taking advantage of React's
Suspenseor other built-in features of Next.js for managing loading states.While this PR doesn't fully address all the points made in the comment, it addresses part of it. Specifically, this PR removes our
/api/user/projectsendpoint, which we previously used alongside SWR to refresh the user's list of projects.Instead, we now fetch the projects directly from our
IProjectDataSourcein theProjectListcomponent. When doing so, we utilizeSuspensewith a fallback that includes the following logic:I have not previously worked with
Suspenseand Next.js' features for managing loading states, so I would greatly appreciate feedback on the approach presented in this PR to learn how to do it best 🙏