Refreshes design #329
Merged
Refreshes design #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/(authed)/(home)/[...slug]/layout.tsx # src/app/(authed)/(home)/[...slug]/page.tsx # src/app/(authed)/layout.tsx # src/common/ui/HighlightText.tsx # src/features/new-project/NewProject.tsx # src/features/sidebar/view/SecondarySplitHeader.tsx # src/features/sidebar/view/internal/sidebar/Sidebar.tsx # src/features/sidebar/view/internal/sidebar/projects/ProjectList.tsx # src/features/sidebar/view/internal/sidebar/projects/ProjectListItem.tsx
ulrikandersen
previously approved these changes
Sep 4, 2024
Contributor
ulrikandersen
left a comment
ulrikandersen
left a comment
There was a problem hiding this comment.
I like the new design a lot, and if we believe we can find time to update screenshots wherever needed, I think we should go with the design pre-FramnaCon 👍
Contributor
Author
Yay! 🙌
I can find time to update the screenshots. Worst case, I don't think it's a blocker if some screenshots aren't up to date. |
Contributor
I absolutely agree 👍 |
ulrikandersen
approved these changes
Sep 5, 2024
Contributor
ulrikandersen
left a comment
ulrikandersen
left a comment
There was a problem hiding this comment.
Really great work 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a refreshed design that emphasizes the documentation and puts the project list in the background.