Fix: Delays error messages until data is refreshed

[mpabarca]

This PR resolves the issue of outdated or inconsistent project data being displayed when loading a project’s details. Previously, error messages such as "Page not found" or "The selected branch or tag was not found" would appear prematurely while data was still being refreshed. The new approach introduces a refreshed state, ensuring that the loading screen remains until the updated project data is fully available.

Additionally, we've added logic to compare new project data with the existing one using deep equality checks to prevent unnecessary updates, further improving performance and reliability.

Loading screens

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[simonbs]

This appears to solve the original issue -- that's amazing! 🙌 However, it also seems to introduce the two issues shown below.

Besides the two issues below, I've also added a small comment that describes a concern about the changes 😊

1. Missing skeleton in header while loading

As shown in the screenshot below, it seems that the skeleton is missing from the header while refreshing projects. That is, we're no longer showing placeholders for the branches, files, and the edit button.

@mpabarca Can you add the skeleton to this page again?

2. Header skeleton shown on "Not Found" page

The skeleton that isn't shown in issue no. 1 is, however, displayed on the "Not Found" page, where it doesn't serve any purpose.

@mpabarca Can you remove it from this page?

[mpabarca]

This appears to solve the original issue -- that's amazing! 🙌 However, it also seems to introduce the two issues shown below.

Besides the two issues below, I've also added a small comment that describes a concern about the changes 😊

1. Missing skeleton in header while loading

As shown in the screenshot below, it seems that the skeleton is missing from the header while refreshing projects. That is, we're no longer showing placeholders for the branches, files, and the edit button.

@mpabarca Can you add the skeleton to this page again?

2. Header skeleton shown on "Not Found" page

The skeleton that isn't shown in issue no. 1 is, however, displayed on the "Not Found" page, where it doesn't serve any purpose.

@mpabarca Can you remove it from this page?

@simonbs Yes, the UI and logic showing the Skeleton is the part that I'm fixing now. When that's done I'll let you know. But thanks for catching up those two! if you find any other one just let me know to fix it!

P.S Another bug that I found is duplication on the messages on not found the version or specification. I'll fix this one too

Screen.Recording.2024-10-07.at.10.51.01.mov

[mpabarca]

This appears to solve the original issue -- that's amazing! 🙌 However, it also seems to introduce the two issues shown below.

Besides the two issues below, I've also added a small comment that describes a concern about the changes 😊

1. Missing skeleton in header while loading

As shown in the screenshot below, it seems that the skeleton is missing from the header while refreshing projects. That is, we're no longer showing placeholders for the branches, files, and the edit button.

@mpabarca Can you add the skeleton to this page again?

2. Header skeleton shown on "Not Found" page

The skeleton that isn't shown in issue no. 1 is, however, displayed on the "Not Found" page, where it doesn't serve any purpose.

@mpabarca Can you remove it from this page?

@simonbs Fixed too 🙌🏼

[simonbs]

Tested the issues with the extraneous and missing skeleton and it looks great now! ✨

@mpabarca I'd appreciate your input on the possible issue mentioned in this comment. Once we've determined that it's either not an issue or have it addressed, I think we should merge this PR 🚀😃

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.