Add support for spaces in specification filenames #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performs a URLDecode of the pathname (e.g. "/acmeorg/foo/main/openapi%20with%20spaces.yml") to make sure we are able to find the file in GitHub.
simonbs
approved these changes
Oct 16, 2024
Contributor
simonbs
left a comment
simonbs
left a comment
There was a problem hiding this comment.
Yay! Thanks for including a unit test 🙌
ulrikandersen
deleted the
fix/support-spaces-in-specification-filenames
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for loading specifications that contains spaces (and other special chars) as part of the filename.
A URLDecode is performed on the pathname (e.g.
/acmeorg/foo/main/openapi%20with%20spaces.yml) to make sure we are able to find the file in GitHub.Motivation and Context
Currently Framna Docs will display that "The selected specification was not found." although the file actually exists in the repository.
Types of changes