Skip to content

Conversation

@simonbs
Copy link
Contributor

@simonbs simonbs commented Feb 3, 2025

This addresses an issue where a recent update to octokit/webhooks.js has caused the build to start failing.

The problem seems to stem from Octokit's chain of dependencies, so for now we'll pin to version 13.4.x.

❯ npm run build

> framna-docs@1.0.0 build
> next build

  ▲ Next.js 14.2.23
  - Environments: .env.local

   Creating an optimized production build ...
Failed to compile.

./node_modules/@octokit/webhooks/dist-bundle/index.js
Attempted import error: 'verifyWithFallback' is not exported from '@octokit/webhooks-methods' (imported as 'verifyWithFallback').

Import trace for requested module:
./node_modules/@octokit/webhooks/dist-bundle/index.js
./node_modules/@octokit/app/dist-web/index.js
./node_modules/octokit/dist-bundle/index.js
./src/common/github/GitHubClient.ts
./src/common/github/index.ts
./src/common/index.ts
./src/features/projects/view/ProjectsContextProvider.tsx

> Build failed because of webpack errors

Copilot AI review requested due to automatic review settings February 3, 2025 13:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@simonbs simonbs changed the title Enhancement/pin octokit Pin to @octokit/webhooks version ~13.4.3 Feb 3, 2025
@simonbs simonbs enabled auto-merge February 3, 2025 13:51
@simonbs
Copy link
Contributor Author

simonbs commented Feb 3, 2025

This also addresses the failing checks in #485.

@simonbs simonbs closed this pull request by merging all changes into develop in a696544 Feb 3, 2025
@simonbs simonbs deleted the enhancement/pin-octokit branch February 3, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants