Upgrades to React 19 #588
Merged
Upgrades to React 19 #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/upgrade-to-react-19
# Conflicts: # package-lock.json # package.json
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Swagger integration to React 19 by removing the swagger-ui-react dependency and dynamically loading the Swagger UI bundle from unpkg.
- Replaces swagger-ui-react with a custom implementation using dynamic script and stylesheet injection.
- Removes unused dependencies from package.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/features/docs/view/Swagger.tsx | Implements dynamic loading of Swagger UI and removes deprecated imports. |
| package.json | Removes swagger-ui-react and its corresponding type definitions. |
Comments suppressed due to low confidence (1)
src/features/docs/view/Swagger.tsx:32
- Verify that window.SwaggerUIBundle is defined before invoking it to prevent runtime errors if the script fails to load.
const SwaggerUI = window.SwaggerUIBundle
ulrikandersen
previously approved these changes
Jun 3, 2025
# Conflicts: # package-lock.json
Contributor
Author
|
@ulrikandersen Thanks! Just fixed the merge conflict. |
auto-merge was automatically disabled
June 3, 2025 13:31
Pull request was converted to draft
Contributor
Author
|
@ulrikandersen I messed up the merge. Have addressed it in 4f9ae49. |
ulrikandersen
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #587 to be merged, as swagger-ui-react is not compatible with React 19.