Use change.id as React key instead of array index #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Array indices as React keys cause rendering issues when lists are reordered or modified. The
DiffChangetype includes anidfield suitable for use as a stable key.This PR updates the diff list components to use
change.idas the React key instead of array indices, and replaces localChangeinterfaces with the properDiffChangetype from the domain layer for type safety.Changes:
change.idas key prop inPopulatedDiffList.tsxChangeinterface withDiffChangetype in bothPopulatedDiffList.tsxandDiffList.tsxBefore:
After:
Motivation and Context
Addresses code review feedback on PR #607: #607 (comment)
Using array indices as React keys is an anti-pattern that can cause rendering bugs when list items are reordered, added, or removed. The
DiffChangeschema already includes a uniqueidfield that provides a stable key for each change item.Screenshots (if appropriate):
N/A
Types of changes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.