✅ Fix npm test
#146
Merged
✅ Fix npm test
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is broken in a fresh install: ``` npm install npm test ``` This is because `npm` will fetch `mongodb@5` (the latest it can), but running `npm test` without the `_SHAREDB_MONGODB_DRIVER` variable set means that the map reduce test still runs, when `mongodb@5` doesn't support it. This change tweaks the test to check if the function is defined, instead of relying on the environment variable.
|
Back port of #145 into v2 |
ericyhwang
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken in a fresh install:
This is because
npmwill fetchmongodb@5(the latest it can), but runningnpm testwithout the_SHAREDB_MONGODB_DRIVERvariable set means that the map reduce test still runs, whenmongodb@5doesn't support it.This change tweaks the test to check if the function is defined, instead of relying on the environment variable.