✅ Add OP_ALREADY_SUBMITTED test for create ops
#658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have [logic][1] that tries to differentiate between: - a create op that is incorrectly trying to create a `Doc` that already exists - a create op that has already been committed, and has been resubmitted (possibly because the connection closed before the ack was received) The latter case is [not currently covered by tests][2]. This change adds a test to cover this branch, and a second similar test which explains why #657 was not a viable change (and correctly fails for that case). [1]: https://github.com/share/sharedb/blob/7b20313ded4c302b9416cc6c7821694a7fa491b8/lib/submit-request.js#L105-L121 [2]: https://coveralls.io/builds/67552613/source?filename=lib%2Fsubmit-request.js#L117
ericyhwang
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have logic that tries to differentiate between:
Docthat already existsThe latter case is not currently covered by tests.
This change adds a test to cover this branch, and a second similar test which explains why #657 was not a viable change (and correctly fails for that case).