DRYing the code #64
aleksandrs-ledovskis
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In the implementation of #63 I have noticed that by cursory look the
fetch_pkg_agefunction is duplicated betweenbrew-safe-upgradeandbrew-safe-installscripts.Unless this is due to some architectural decision, the general convention is to simplify and extract common code blocks to a reusable module which can be included in multiple places.
So, my suggestion is to improve this area a bit - improve the code by DRY'ing and re-checking for conformance to Shell script development best practices and formatting.
Beta Was this translation helpful? Give feedback.
All reactions