Fix ScriptLoaderService to use WARN level for script loading failures #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ScriptLoaderService was logging script loading failures at ERROR level, which could trigger unnecessary alarms in monitoring systems when failures are expected (e.g., ad blockers preventing Google Analytics from loading).
Changes
Changed the log level from
ERRORtoWARNwhen scripts fail to load:This change allows consumer code to decide how to handle script loading failures. The service still:
ScriptLoaderErrorobjects with all detailsExample Impact
Consider loading Google Analytics with an ad blocker:
Before: Service logs at ERROR level → monitoring alarms triggered
After: Service logs at WARN level → no false alarms, consumer controls error handling
Added comprehensive test coverage to verify the new logging behavior while ensuring all existing functionality remains intact.
Fixes #52.