Switch to the other yq #220
Conversation
Annoyingly, there are two versions of yq: a comment in this file suggested we were using the Go-based version [1] but our usage indicated we were actually using the Python-based version [2]. Switch fully to the Go-based version, since that's available in the repos. [1] https://github.com/mikefarah/yq [2] https://github.com/kislyuk/yq Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Depends on [1]. [1] shiftstack/shiftstack-ci#220 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
/lgtm That's super annoying to have two different implementations for the same thing, especially, that big chunk of linux distros is using python version :/ |
Depends on [1]. [1] shiftstack/shiftstack-ci#220 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
/retest |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Annoyingly, there are two versions of yq: a comment in this file suggested we were using the Go-based version [1] but our usage indicated we were actually using the Python-based version [2].
Switch fully to the Go-based version, since that's available in the repos.
[1] https://github.com/mikefarah/yq
[2] https://github.com/kislyuk/yq