Skip to content

[BUG] ko Build Strategy Resources Too Low #2011

@adambkaplan

Description

@adambkaplan

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

Client Version: v1.33.0
Kustomize Version: v5.6.0
Server Version: v1.34.0

Shipwright Version

v0.17.0

Current Behavior

When building with the ko sample build strategy, the default resource limits for the build step are too low, and the container is prone to run out of memory even for a simple application.

Expected Behavior

The build strategy should default to higher resource limits for the build step, since it requires code to be compiled. Suggesting 1 CPU and 2Gi RAM for limits. The resource request should also be increased.

Steps To Reproduce

  1. Create a build using the sample ko build strategy.
  2. Run the build using a reasonably sized go project.

Tested with https://github.com/adambkaplan/quizap (using the "backend" as a context dir)

Anything else?

Related feature that would address this: #1894

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions