This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Autocorrection MissingRequiredTemplateFiles#385
Merged
hannakebedom merged 1 commit intomainfrom Sep 9, 2021
Merged
Conversation
hannakebedom
changed the title
MissingRequiredTemplateFiles
hannakebedom
changed the title
MissingRequiredTemplateFilesMissingRequiredTemplateFiles
hannakebedom
force-pushed
the
auto_correct_missing_required_template_files
branch
from
5cc2e94 to
faa0e6a
Compare
macournoyer
approved these changes
Aug 12, 2021
Contributor
macournoyer
left a comment
macournoyer
left a comment
There was a problem hiding this comment.
Awesome, you're on 🔥 !
I think it's missing for the same reason I mentioned in #388 (comment)
hannakebedom
force-pushed
the
auto_correct_missing_required_template_files
branch
3 times, most recently
from
218a285 to
2602680
Compare
hannakebedom
force-pushed
the
auto_correct_missing_required_template_files
branch
from
2602680 to
99a624f
Compare
tristan-potter
approved these changes
Sep 9, 2021
| (REQUIRED_TEMPLATE_FILES - (theme.liquid + theme.json).map(&:name)).each do |file| | ||
| add_offense("'#{file}.liquid' or '#{file}.json' is missing") | ||
| add_offense("'#{file}.liquid' or '#{file}.json' is missing") do |corrector| | ||
| if REQUIRED_LIQUID_TEMPLATE_FILES.include?(file) |
hannakebedom
deleted the
auto_correct_missing_required_template_files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Makes sure all of the required template files in a theme are present.
How does it do it?
Automatically creates required template files if they don't already exist.
Why did you pick this approach over other options?
This approach uses methods on the corrector class to create the template files that are missing