Fix Windows bugs by charlespwd · Pull Request #415 · Shopify/theme-check

charlespwd · 2021-08-30T20:18:02Z

Fixes #413

Things that happened:

VS Code sends Windows paths as file:///c%3A/... (note the third slash)
We were not sending URIs back properly (reencoding them)
We were not receiving the URIs properly (decoding them)
offenses.sort_by(:location)'s behaviour was not deterministic since it was possible that two errors showed up at the same location. I have added sort_by location + message, this way it should be more deterministic.
I added Windows CI.
I went with $stdout.binmode instead of the Gem.win_platform? hack. We had another bug in the unit tests (on Windows) because of that.

macournoyer

Awesome work! 🔥

I'm only worried about binmode and encoding. But if you tested. All good!

.github/workflows/theme-check.yml

lib/theme_check/language_server/handler.rb

lib/theme_check/language_server/server.rb

lorand-horvath · 2021-09-06T19:25:35Z

@charlespwd These Windows bugs seem quite intricate, nice to see you're crushing them one-by-one! Is there hope for a newer theme-check & theme-check-vscode version in the near future? I'm still using themekit for windows... not confident enough to try Shopify CLI with theme-check yet :)

mrseankumar25 · 2021-09-07T05:54:50Z

@charlespwd These Windows bugs seem quite intricate, nice to see you're crushing them one-by-one! Is there hope for a newer theme-check & theme-check-vscode version in the near future? I'm still using themekit for windows... not confident enough to try Shopify CLI with theme-check yet :)

I also agree with @lorand-horvath

charlespwd · 2021-09-07T15:14:39Z

Hey @lorand-horvath, @mrseankumar25!

We just released theme-check 1.5.0, (and a small bugfix in theme-check-vscode 1.1.4). Please let us know if you have any issues!

gem update theme-check should get you covered.

I might say "I think this is the one 🤞" but I don't want to jinx myself. So consider that I didn't say that :)

lorand-horvath · 2021-09-07T16:58:19Z

@charlespwd Thanks for the heads up, but I've just noticed a couple of issues with the latest theme-check-vscode 1.1.4
Please check the issue I opened there Shopify/theme-check-vscode#45
Thanks!

furnaceX · 2021-09-08T23:49:29Z

I've installed the theme-check 1.5.0 and have some new errors:

Checking c:/Users/ScottJ/Documents/ShopifyDev/Gales/GalesWIP
Exception while running `PaginationSize#after_document`:

NoMethodError: undefined method `empty?' for nil:NilClass
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks/pagination_size.rb:58:in `get_setting_default_value'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks/pagination_size.rb:44:in `block in after_document'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks/pagination_size.rb:40:in `each_pair'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks/pagination_size.rb:40:in `after_document'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:42:in `block in call_check_method'
  C:/Ruby30-x64/lib/ruby/3.0.0/timeout.rb:97:in `block in timeout'
  C:/Ruby30-x64/lib/ruby/3.0.0/timeout.rb:35:in `block in catch'
  C:/Ruby30-x64/lib/ruby/3.0.0/timeout.rb:35:in `catch'
  C:/Ruby30-x64/lib/ruby/3.0.0/timeout.rb:35:in `catch'
  C:/Ruby30-x64/lib/ruby/3.0.0/timeout.rb:112:in `timeout'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:41:in `call_check_method'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:11:in `block in call'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:10:in `each'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:10:in `call'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:35:in `call_checks'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:26:in `visit'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:12:in `visit_template'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:39:in `block (2 levels) in analyze_theme'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:38:in `each'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:38:in `block in analyze_theme'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check.rb:57:in `with_liquid_c_disabled'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:37:in `analyze_theme'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:144:in `block in analyze_and_send_offenses'
  C:/Ruby30-x64/lib/ruby/3.0.0/benchmark.rb:293:in `measure'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:143:in `analyze_and_send_offenses'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:61:in `on_text_document_did_open'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:105:in `process_request'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:45:in `block in listen'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:44:in `loop'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:44:in `listen'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server.rb:27:in `start'
  C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/exe/theme-check-language-server:10:in `<top (required)>'
  C:/Ruby30-x64/bin/theme-check-language-server:23:in `load'
  C:/Ruby30-x64/bin/theme-check-language-server:23:in `<main>'

Template: `old/sections/blog-template.liquid`
Node: `Liquid::Document`
Markup:

Check options: `{:min_size=>1, :max_size=>50}
`
Theme Check Version: 1.5.0
Ruby Version: 3.0.2
Platform: x64-mingw32
Muffin mode: activated

------------------------
Whoops! It looks like you found a bug in Theme Check.
Please report it at https://github.com/Shopify/theme-check/issues, and include the message above.
Or cross your fingers real hard, and try again.
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/bug.rb:20:in `bug'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:54:in `rescue in call_check_method'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:29:in `call_check_method'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:11:in `block in call'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:10:in `each'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/checks.rb:10:in `call'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:35:in `call_checks'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:26:in `visit'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/visitor.rb:12:in `visit_template'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:39:in `block (2 levels) in analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:38:in `each'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:38:in `block in analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check.rb:57:in `with_liquid_c_disabled'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/analyzer.rb:37:in `analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:144:in `block in analyze_and_send_offenses'
C:/Ruby30-x64/lib/ruby/3.0.0/benchmark.rb:293:in `measure'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:143:in `analyze_and_send_offenses'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/handler.rb:61:in `on_text_document_did_open'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:105:in `process_request'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:45:in `block in listen'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:44:in `loop'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server/server.rb:44:in `listen'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/lib/theme_check/language_server.rb:27:in `start'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.0/exe/theme-check-language-server:10:in `<top (required)>'
C:/Ruby30-x64/bin/theme-check-language-server:23:in `load'
C:/Ruby30-x64/bin/theme-check-language-server:23:in `<main>'
[Info  - 5:42:49 PM] Connection to server got closed. Server will restart.
[Error - 5:42:49 PM] Request textDocument/documentLink failed.
Error: Connection got disposed.
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:35828)
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116000)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116213)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:176601)
	at t (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:114302)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at Y (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:25086)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at m.fireClose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:46083)
	at Socket.<anonymous> (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:47668)
	at Socket.emit (events.js:327:22)
	at Socket.EventEmitter.emit (domain.js:467:12)
	at Pipe.<anonymous> (net.js:673:12)

mrseankumar25 · 2021-09-09T07:27:08Z

I also get same issue:

charlespwd · 2021-09-09T12:02:53Z

This has just got fixed in 1.5.1

furnaceX · 2021-09-09T18:43:05Z

I've installed the theme-check 1.5.2 and have some new errors:

Checking c:/Users/ScottJ/Documents/ShopifyDev/Gales/GalesWIP
undefined method `[]' for nil:NilClass
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_node.rb:72:in `block in replace_placeholders'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_node.rb:71:in `gsub'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_node.rb:71:in `replace_placeholders'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_node.rb:60:in `markup'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/checks.rb:51:in `rescue in call_check_method'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/checks.rb:29:in `call_check_method'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/checks.rb:11:in `block in call'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/checks.rb:10:in `each'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/checks.rb:10:in `call'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:51:in `call_checks'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:41:in `visit'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:43:in `block in visit'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:43:in `each'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:43:in `visit'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/html_visitor.rb:17:in `visit_template'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/analyzer.rb:40:in `block (2 levels) in analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/analyzer.rb:38:in `each'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/analyzer.rb:38:in `block in analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check.rb:57:in `with_liquid_c_disabled'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/analyzer.rb:37:in `analyze_theme'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/handler.rb:144:in `block in analyze_and_send_offenses'
C:/Ruby30-x64/lib/ruby/3.0.0/benchmark.rb:293:in `measure'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/handler.rb:143:in `analyze_and_send_offenses'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/handler.rb:61:in `on_text_document_did_open'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/server.rb:105:in `process_request'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/server.rb:45:in `block in listen'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/server.rb:44:in `loop'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server/server.rb:44:in `listen'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/lib/theme_check/language_server.rb:27:in `start'
C:/Ruby30-x64/lib/ruby/gems/3.0.0/gems/theme-check-1.5.2/exe/theme-check-language-server:10:in `<top (required)>'
C:/Ruby30-x64/bin/theme-check-language-server:23:in `load'
C:/Ruby30-x64/bin/theme-check-language-server:23:in `<main>'
[Info  - 12:38:20 PM] Connection to server got closed. Server will restart.
[Error - 12:38:20 PM] Request textDocument/documentLink failed.
Error: Connection got disposed.
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:35828)
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116000)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116213)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:176601)
	at t (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:114302)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at Y (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:25086)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at m.fireClose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:46083)
	at Socket.<anonymous> (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:47668)
	at Socket.emit (events.js:327:22)
	at Socket.EventEmitter.emit (domain.js:467:12)
	at Pipe.<anonymous> (net.js:673:12)
[Error - 12:38:20 PM] Request textDocument/documentLink failed.
Error: Connection got disposed.
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:35828)
	at Object.dispose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116000)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:116213)
	at w.handleConnectionClosed (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:176601)
	at t (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:114302)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at Y (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:25086)
	at r.invoke (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:37441)
	at o.fire (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:38202)
	at m.fireClose (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:46083)
	at Socket.<anonymous> (c:\Users\ScottJ\.vscode\extensions\shopify.theme-check-vscode-1.1.5\dist\extension.js:1:47668)
	at Socket.emit (events.js:327:22)
	at Socket.EventEmitter.emit (domain.js:467:12)
	at Pipe.<anonymous> (net.js:673:12)
[Error - 12:38:20 PM] Request textDocument/documentLink failed.
Error: Connection got disposed.

charlespwd · 2021-09-09T19:31:53Z

That's something different, I'll open an issue. Thanks for reporting!

// Thanks for your patience with this. Seems like we're missing a bunch of curve balls here.

furnaceX · 2021-09-09T20:05:30Z

I can do some more real-time testing if you need.

charlespwd force-pushed the fix/413-windows-grep branch 6 times, most recently from a09cb88 to 5ba4f0a Compare August 31, 2021 20:32

charlespwd added 3 commits September 1, 2021 09:29

Ignore .vscode folders

4bf898b

Add Windows CI

9c29473

Fix all ze Windows bugs

5810119

charlespwd force-pushed the fix/413-windows-grep branch from 54d5b44 to dfd1a21 Compare September 1, 2021 13:32

charlespwd changed the title ~~Fix Windows glob bug (WIP)~~ Fix Windows bugs Sep 1, 2021

charlespwd requested a review from macournoyer September 1, 2021 13:32

charlespwd marked this pull request as ready for review September 1, 2021 13:33

macournoyer approved these changes Sep 1, 2021

View reviewed changes

.github/workflows/theme-check.yml Show resolved Hide resolved

lib/theme_check/language_server/handler.rb Outdated Show resolved Hide resolved

lib/theme_check/language_server/server.rb Outdated Show resolved Hide resolved

lib/theme_check/language_server/server.rb Show resolved Hide resolved

charlespwd added 2 commits September 1, 2021 15:25

Switch stdout to binmode to fix the Windows thing

0bdefa8

Cleanup file path/uri conversion

bb5b29b

charlespwd force-pushed the fix/413-windows-grep branch from 4b8cdb7 to bb5b29b Compare September 1, 2021 19:25

charlespwd merged commit 3341127 into main Sep 1, 2021

shopify-shipit bot temporarily deployed to rubygems September 7, 2021 14:32 Inactive

ADTC mentioned this pull request Sep 24, 2021

Windows path gives invalid argument for this code line #464

Closed

Conversation

charlespwd commented Aug 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macournoyer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lorand-horvath commented Sep 6, 2021

Uh oh!

mrseankumar25 commented Sep 7, 2021

Uh oh!

charlespwd commented Sep 7, 2021

Uh oh!

lorand-horvath commented Sep 7, 2021

Uh oh!

furnaceX commented Sep 8, 2021

Uh oh!

mrseankumar25 commented Sep 9, 2021

Uh oh!

charlespwd commented Sep 9, 2021

Uh oh!

furnaceX commented Sep 9, 2021

Uh oh!

charlespwd commented Sep 9, 2021

Uh oh!

furnaceX commented Sep 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

charlespwd commented Aug 30, 2021 •

edited

Loading