This repository was archived by the owner on Jan 4, 2022. It is now read-only.
[CON-4522] Move drop shipping options to import tab #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keulinho
reviewed
Jan 2, 2018
Bootstrap/Update.php
Outdated
|
|
||
| private function changeGroupNameImportSettings() | ||
| { | ||
| if (version_compare($this->version, '1.1.12', '<=')) { |
Collaborator
There was a problem hiding this comment.
$this->versioncontains the old version so when updating from 1.1.11 to 1.1.12 it would contain 1.1.11
i think you have to check less or eguals '1.1.11'
in general it is Version_with_that_change - 1
keulinho
reviewed
Jan 2, 2018
plugin.json
Outdated
| "currentVersion": "1.1.11", | ||
| "changelog": { | ||
| "de": { | ||
| "1.1.12": "CON-4522: Drop shipping Einstellungen in den Import Tab verschoben", |
Collaborator
There was a problem hiding this comment.
in general i would not add the changelog in this moment because you never really know with wich release your PR is realesed.
The workflow is to flag the jira ticket with the plugin version you think and then when we want to do package test we add al changelogs for that release
keulinho
approved these changes
Jan 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #443