This repository was archived by the owner on Jan 4, 2022. It is now read-only.
Con 5203: Fix renaming variant options #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianFranze
suggested changes
Apr 17, 2018
Components/VariantConfigurator.php
Outdated
| $detail->setConfiguratorOptions($detailOptions); | ||
| $this->manager->persist($detail); | ||
| $this->manager->persist($article); | ||
| $this->manager->persist($article); |
Contributor
There was a problem hiding this comment.
Warum zweimal persist?
Components/VariantConfigurator.php
Outdated
|
|
||
| $this->manager->flush(); | ||
|
|
||
|
|
|
|
||
| $configSet->getOptions()->removeElement($detailOption); | ||
|
|
||
| $this->manager->flush(); |
Contributor
There was a problem hiding this comment.
muss flush in jedem Schleifendurchlauf?
Contributor
Author
There was a problem hiding this comment.
Leider ja :(
keulinho
suggested changes
Apr 18, 2018
| foreach ($options as $option) { | ||
| $optionCollection->removeElement($option); | ||
| } | ||
| $configSet->setOptions($options); |
Collaborator
There was a problem hiding this comment.
does setOptions() append or does it overwrite the list of options?
i think it overrides and then the whole foreach is not necessary
| { | ||
| $connection = $this->manager->getConnection(); | ||
| $query = $connection->prepare( | ||
| 'SELECT option_id FROM s_article_configurator_set_option_relations WHERE option_id = :optionId UNION |
keulinho
approved these changes
Apr 18, 2018
SebastianFranze
approved these changes
Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.