This repository was archived by the owner on Jan 4, 2022. It is now read-only.
[CON-5276] make plugin compatible with 5.5 #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored ProductFromShop; adjusted ProductFromShopTest
keulinho
approved these changes
Jun 21, 2018
| ]; | ||
| } | ||
|
|
||
| private function createRandomAddress() |
| "compatibility": { | ||
| "minimumVersion": "5.2.0", | ||
| "maximumVersion": "5.4.4", | ||
| "maximumVersion": "5.5.0", |
Collaborator
There was a problem hiding this comment.
ich weiß nicht ob das sbp das so frisst vor dem offiziellen release von 5.5
Contributor
Author
There was a problem hiding this comment.
Probieren, sonst muss es wieder raus
SebastianFranze
commented
Jun 21, 2018
| new Criteria(), | ||
| Shopware()->Container()->get('shopware_storefront.context_service')->getShopContext()) | ||
| ); | ||
| ->willReturn($ps); |
Contributor
Author
There was a problem hiding this comment.
Keine Ahnung warum aber es wollte lokal einfach nicht laufen, wenn der Constructor in der Funktion aufgerufen wurde
SebastianFranze
commented
Jun 21, 2018
| private function getInvoicePayment() | ||
| { | ||
| $repository = $this->manager->getRepository('Shopware\Models\Payment\Payment'); | ||
| return $repository->findOneBy([ |
Contributor
Author
There was a problem hiding this comment.
Das sollte hoffentlich gecached werden, wenn wir die Funktion später zweimal aufrufen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.