Skip to content

SG-13267: Config fixes for Mockgun #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2019
Merged

SG-13267: Config fixes for Mockgun #215

merged 6 commits into from
Oct 23, 2019
+55 −8

Conversation

@jfboismenu
Copy link
Contributor

@jfboismenu jfboismenu commented Oct 23, 2019 •
edited
Loading

Mockgun never initialized the values inside the _Config instance, which is causing some issues in Python 3 because of None values being passed into urllib methods.

I've added the required tests.

hound[bot]
hound bot reviewed Oct 23, 2019
View reviewed changes
willis102
willis102 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@willis102 willis102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@willis102
Copy link
Contributor

willis102 commented Oct 23, 2019 •
edited
Loading

I'm going to merge this onto SG-13264-update_sgsix and I'll be updating the python3 branch on tk-core with the latest from there.

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1282

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 68.559%
Totals Coverage Status
Change from base Build 1267: -0.2%
Covered Lines: 5397
Relevant Lines: 7872
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1282

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 68.77%
Totals Coverage Status
Change from base Build 1267: 0.05%
Covered Lines: 6767
Relevant Lines: 9840
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 23, 2019

Pull Request Test Coverage Report for Build 1282

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 68.77%
Totals Coverage Status
Change from base Build 1267: 0.05%
Covered Lines: 6767
Relevant Lines: 9840
💛 - Coveralls

@jfboismenu jfboismenu merged commit 7d2e224 into master Oct 23, 2019
@jfboismenu jfboismenu deleted the SG-13267_shotgutils_python3_port branch October 23, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hound hound[bot] hound[bot] left review comments

@willis102 willis102 willis102 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfboismenu @willis102 @coveralls