Skip to content

Conversation

@julien-lang
Copy link
Contributor

Should have been removed in #372.

This class is no longer used since we remove the compatibility with Python 2.

This PR replaces #415 and #394.

Closes #394
Closes #415

@julien-lang julien-lang requested a review from Copilot October 15, 2025 18:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the unused CACertsHTTPSConnection class that became obsolete after dropping Python 2 compatibility, cleaning up dead and broken code.

  • Remove deprecated and unused CACertsHTTPSConnection implementation.
  • Simplify codebase by eliminating legacy certificate handling logic.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@julien-lang julien-lang marked this pull request as ready for review October 15, 2025 18:41
@julien-lang julien-lang requested a review from a team October 15, 2025 18:41
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-lang julien-lang merged commit 36724cf into master Oct 16, 2025
22 checks passed
@julien-lang julien-lang deleted the ticket/SG-40026-cleanup-unused-code branch October 16, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants