Trigger clip:selected event on resize completion#6
Closed
ferozhussain wants to merge 1 commit intoshotstack:mainfrom
Closed
Trigger clip:selected event on resize completion#6ferozhussain wants to merge 1 commit intoshotstack:mainfrom
ferozhussain wants to merge 1 commit intoshotstack:mainfrom
Conversation
Contributor
|
This makes sense. I'll test and get this merged. |
Contributor
|
We should separate selection from state updates by:
Proposed {
previous: {
clip: { ...previousConfig },
trackIndex: previousTrackIndex,
clipIndex: previousClipIndex
},
current: {
clip: { ...currentConfig },
trackIndex: currentTrackIndex,
clipIndex: currentClipIndex
}
}This separation follows standard event system patterns, improves code clarity, and future-proofs our implementation. |
Author
|
Agreed |
Contributor
|
Closing this PR as the changes have been implemented in PR #9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clip selection behavior to trigger the
clip:selectedevent not only when a clip is clicked, but also when a clip resize or rotation operation is completed. This ensures that applications can respond to all types of clip interactions through a single event handler.Changes
Updated the
onPointerUpmethod in the Player class to trigger thesetSelectedClipmethod when:A clip is clicked (existing behavior)
A clip scaling operation is completed
A clip rotation operation is completed