fix connector + azure #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
ok @shyiko I've got a connection to Azure working. This was a particularly tough one to solve, the code to respond to Azure's switch-auth message was simple enough, but if you look at my (admittedly hacked up) changes in I can make the code much cleaner but I thought I'd show you in code what I found. |
Owner
|
Great job, Ben! LGTM |
Azure has a couple of differences from stock mysql. First, it always sends a "switch auth" packet back from the first auth request. If you google "azure mysql handshake" you'll find a bunch of other libraries that had to deal with this. Second, it's rather persnickitty with the response to this; if we send the response a byte or so at a time azure just closes our connection.
osheroff
force-pushed
the
ben/azure_mysql
branch
from
88147d7 to
7a93eec
Compare
osheroff
changed the title
Collaborator
Author
|
ok @shyiko this is ready to merge now |
Owner
|
🥇 |
Owner
|
@osheroff 0.20.0 deployed to Maven Central |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't merge. just showing where I'm at.