-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: depricate cheriot, upgrade merino to Nuxt 4 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we writing an eslint-config? if not, should we consider doing so to adapt some useful internal rules we have?
same, potentially, with tsconfig
src/configs/prisma.ts
Outdated
{ | ||
name: 'vite-node', | ||
version: '^2.1.5', | ||
version: '0.3.0-beta.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test this? I checked this version out and it was not working for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had seen that on one of our projects we use this version! But this could also be due to them using the Docker-database setup.
Ill revert it down to beta.3 as its more battle-tested!
Yes, we are. However its harder to push package-related rules (e.g. importing prisma enums, trpc procedure imports) etc. and I wanted to avoid always shipping these. But I think its a great idea to look into for the future as an extension 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - as discussed orally before you had merged this. Thanks for landing this nice update (:
This PR:
prisma-client
providerChecklist:
#
)