fix: allocation partition size for gaps #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
commented
Nov 13, 2025
| lowLBA: lowLBA, | ||
| highLBA: highLBA, | ||
| partitionIdx: partitionIdx, | ||
| size: (highLBA - lowLBA) * uint64(t.sectorSize), |
Member
Author
There was a problem hiding this comment.
wrong size calculation here previously - both high and low LBAs are inclusive, so +1
smira
commented
Nov 13, 2025
| highLBA = t.entries[partitionIdx].FirstLBA - 1 | ||
| } else { | ||
| highLBA = t.lastUsableLBA | ||
| highLBA = highLBA/t.alignment*t.alignment - 1 |
Member
Author
There was a problem hiding this comment.
we don't need to decrement -1 here, but to keep the code from trying to grow the last partition on the disk, a small fix up to compensate for the previous bug
Member
Author
There was a problem hiding this comment.
1 here is 1 LBA, 1 sector, so 512 bytes wasted
smira
commented
Nov 13, 2025
| expectedGdiskDump: loadTestdata(t, "allocate.gdisk"), | ||
| }, | ||
| { | ||
| name: "allocate with small delete", |
We don't need to align highLBA (or the end of the next partition), as otherwise we can't drop and re-create the partition in the same place. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Fix linting issues. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/partition-alloc-v2
branch
from
b61e1de to
1216693
Compare
shanduur
approved these changes
Nov 14, 2025
Member
Author
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Nov 14, 2025
Pulls in siderolabs/go-blockdevice#139. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Nov 14, 2025
Pulls in siderolabs/go-blockdevice#139. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to align highLBA (or the end of the next partition), as
otherwise we can't drop and re-create the partition in the same place.