fix: improve KVS update method error handling #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if key exists before attempting update - Return ErrNotFound when key doesn't exist - Improve error message for JSON marshalling failures
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the KVS repository's update method by adding proper existence checks and providing more descriptive error messages for marshalling failures.
- Added key existence validation before attempting update operations
- Replaced generic error responses with more specific and descriptive error messages
- Enhanced error handling consistency by returning appropriate errors for different failure scenarios
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| data, err := json.Marshal(value) | ||
| if err != nil { | ||
| return fosite.ErrNotFound | ||
| return fmt.Errorf("failed to marshal value: %w", err) |
There was a problem hiding this comment.
Missing import for fmt package. The code uses fmt.Errorf but there's no visible import statement for the fmt package in the diff context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves error handling in the KVS repository update method by properly checking if a key exists before attempting to update it and providing better error messages for JSON marshalling failures.
Type of Change
Related Issues
Changes Made
fosite.ErrNotFoundwhen attempting to update non-existent keyErrNotFoundto more descriptive errorTesting
The changes improve error handling consistency and provide more accurate error responses when operations fail.