Skip to content

fix: improve KVS update method error handling #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix: improve KVS update method error handling #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/repository/kvs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,12 @@ func (r *kvsRepository) delete(ctx context.Context, key string) error {
func (r *kvsRepository) update(ctx context.Context, key string, value any) error {
return r.db.Update(func(tx *bbolt.Tx) error {
bucket := tx.Bucket([]byte(r.bucketName))
if bucket.Get([]byte(key)) == nil {
return fosite.ErrNotFound
}
data, err := json.Marshal(value)
if err != nil {
return fosite.ErrNotFound
return fmt.Errorf("failed to marshal value: %w", err)
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import for fmt package. The code uses fmt.Errorf but there's no visible import statement for the fmt package in the diff context.

Copilot uses AI. Check for mistakes.
}
return bucket.Put([]byte(key), data)
})
Expand Down