fix: remove oauth2.AccessTypeOffline from AuthCodeURL calls #41
Conversation
Remove oauth2.AccessTypeOffline parameter from AuthCodeURL calls in both GitHub and Google OAuth providers as it's not needed for the authorization code flow and may cause issues with some OAuth implementations.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the oauth2.AccessTypeOffline parameter from OAuth authorization code URL generation to fix compatibility issues with OAuth providers. The change affects both GitHub and Google OAuth implementations.
- Removes
oauth2.AccessTypeOfflinefromAuthCodeURLcalls in OAuth providers - Simplifies OAuth flow implementation by removing unnecessary parameter
- Addresses potential compatibility issues with OAuth implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/auth/google.go | Removes oauth2.AccessTypeOffline parameter from Google OAuth provider's AuthCodeURL method |
| pkg/auth/github.go | Removes oauth2.AccessTypeOffline parameter from GitHub OAuth provider's AuthCodeURL method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| func (p *googleProvider) AuthCodeURL(c *gin.Context, state string) (string, error) { | ||
| authURL := p.oauth2.AuthCodeURL(state, oauth2.AccessTypeOffline) | ||
| authURL := p.oauth2.AuthCodeURL(state) |
There was a problem hiding this comment.
Removing oauth2.AccessTypeOffline may prevent obtaining refresh tokens for Google OAuth. For Google's OAuth2 implementation, AccessTypeOffline is typically required to receive refresh tokens that allow offline access to user data. Consider if refresh token functionality is needed for this application.
| authURL := p.oauth2.AuthCodeURL(state) | |
| authURL := p.oauth2.AuthCodeURL(state, oauth2.AccessTypeOffline) |
There was a problem hiding this comment.
Refresh tokens are not used.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Remove
oauth2.AccessTypeOfflineparameter fromAuthCodeURLcalls in both GitHub and Google OAuth providers. This parameter is not needed for the authorization code flow and may cause compatibility issues with some OAuth implementations.Type of Change
Related Issues
Changes Made
oauth2.AccessTypeOfflinefrom GitHub provider'sAuthCodeURLmethodoauth2.AccessTypeOfflinefrom Google provider'sAuthCodeURLmethodTesting