Skip to content

fix: remove oauth2.AccessTypeOffline from AuthCodeURL calls #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix: remove oauth2.AccessTypeOffline from AuthCodeURL calls #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/auth/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (p *githubProvider) AuthURL() string {
}

func (p *githubProvider) AuthCodeURL(c *gin.Context, state string) (string, error) {
authURL := p.oauth2.AuthCodeURL(state, oauth2.AccessTypeOffline)
authURL := p.oauth2.AuthCodeURL(state)
return authURL, nil
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/auth/google.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (p *googleProvider) RedirectURL() string {
}

func (p *googleProvider) AuthCodeURL(c *gin.Context, state string) (string, error) {
authURL := p.oauth2.AuthCodeURL(state, oauth2.AccessTypeOffline)
authURL := p.oauth2.AuthCodeURL(state)
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing oauth2.AccessTypeOffline may prevent obtaining refresh tokens for Google OAuth. For Google's OAuth2 implementation, AccessTypeOffline is typically required to receive refresh tokens that allow offline access to user data. Consider if refresh token functionality is needed for this application.

Suggested change
authURL := p.oauth2.AuthCodeURL(state)
authURL := p.oauth2.AuthCodeURL(state, oauth2.AccessTypeOffline)

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@hrntknr hrntknr Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh tokens are not used.

return authURL, nil
}

Expand Down