fix: improve KVS repository error handling #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use fosite.ErrNotFound for consistent error responses - Remove redundant bucket existence checks - Simplify error handling in update method
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the KVS repository by standardizing error types and removing unnecessary bucket existence checks.
- Replace custom error messages with standardized fosite error types
- Remove redundant bucket existence checks that are unnecessary when accessing existing buckets
- Simplify error handling logic in delete and update operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| data, err := json.Marshal(value) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal value: %w", err) | ||
| return fosite.ErrNotFound |
There was a problem hiding this comment.
Returning fosite.ErrNotFound for a JSON marshaling error is incorrect. This error type should only be used when a resource is not found, not when serialization fails. The original error wrapping should be retained: return fmt.Errorf(\"failed to marshal value: %w\", err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Brief description of what this PR accomplishes)
Type of Change
Related Issues